Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken links in README.md and rules.md #610

Closed
wants to merge 2 commits into from

Conversation

youyyytrok
Copy link

Changes introduced

  • Updated incorrect and outdated links in:
    • README.md:
      • Fixed project website link: https://protofire.io/projects/solhinthttps://protofire.io/solhint.
    • docs/rules.md:
      • Updated ConsenSys guide link:
        https://consensys.github.io/smart-contract-best-practices/recommendations/https://consensys.github.io/smart-contract-best-practices/development-recommendations/.

@youyyytrok
Copy link
Author

Hi @dbale-altoros pls check this PR

@dbale-altoros
Copy link
Collaborator

thanks for this
the readme fix is ok
the other one points out the broken link but it is not fixing it
the file you modified is generated automatically
you can see at the top the legend
"This is a dynamically generated file. Do not edit manually."

I will fix this in a separate pr with other typos
thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants