Update to latest stack version and fix warnings.#41
Closed
cdepillabout wants to merge 6 commits intoprowdsponsor:masterfrom
Closed
Update to latest stack version and fix warnings.#41cdepillabout wants to merge 6 commits intoprowdsponsor:masterfrom
cdepillabout wants to merge 6 commits intoprowdsponsor:masterfrom
Conversation
Author
|
I think I'm going to send a could more PRs over the next week. I might also want the other open PR merged in. @meteficha If you wanted to make me a member for |
bitc
reviewed
Sep 30, 2016
fb.cabal
Outdated
| , http-conduit >= 2.0 && < 2.2 | ||
| , attoparsec >= 0.10.4 && < 0.14 | ||
| , unordered-containers | ||
| , aeson >= 0.5 |
There was a problem hiding this comment.
This should be bumped up to aeson >= 0.7 since that is when the function encodeToTextBuilder was introduced (which you use in this PR)
|
@meteficha +1 to the above for giving @cdepillabout access to do a release :) |
Author
|
@bitc Thanks for the heads-up! I've bumped the aeson dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a couple different changes:
origin/mastercurrently does not compile on 7.8, so everything about 7.8 was removed..travis.yml. You can checkout the tests here. It's currently being tested on a couple recent versions of stackage, along with raw cabal. Everything is passing (other than GHC HEAD)..travis.ymlwas adapted from here.README.md.