Fix some noises when using mk25 (12v) #81
+102
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzbischoff
commented
Dec 2, 2018
franzbischoff
commented
- Fix mk25: whistle before boot and when in management mode
- Fix mk25: pulley rattle noise
* Fix mk25: pulley rattle noise
# Conflicts: # MM-control-01/Buttons.cpp
# Conflicts: # MM-control-01/main.cpp # MM-control-01/main.h # MM-control-01/mmctl.cpp # MM-control-01/mmctl.h # MM-control-01/motion.cpp # MM-control-01/stepper.cpp # MM-control-01/version.h.in
|
Thank you for your proposal. I am not going to merge this, as it would lead to separate firmware for MMUv2 to be used with 12V and 24V printers. I hope that part of this problem (whistling in calibration menu) was already fixed by rewriting this menu to be non-blocking, so command from printer to switch to silent mode is processed earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.