chore(BlockByTimestamp): Remove unnecessary conversion and infeasible check, add a case in findMinTargetEth1Block
#13829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letonchanh
changed the title
findMinTargetEth1Block
prestonvanloon
force-pushed
the
fix-block-by-timestamp
branch
from
76ff926
to
bb9ccc4
Compare
prestonvanloon
previously approved these changes
Aug 23, 2024
auto-merge was automatically disabled
August 27, 2024 19:19
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
findMinTargetEth1Block, handle an additional case when the header with the current number does not exist, then return the previous header, the latest header whose timestamp is just earlier than the target time.cursorNumfrom*big.Inttouint64to avoid unnecessary conversion frombig.Inttouint64.retrieveHeaderInfoas the case is already handled byHeaderByNumber.Which issues(s) does this PR fix?
N/A
Other notes for review