Update to v1.5.0-alpha.3 spec tests #14112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,7 +73,6 @@ type ReadOnlyBeaconBlockBody interface { | |||
|
|
|||
| type ROBlockBodyElectra interface { | |||
| ReadOnlyBeaconBlockBody | |||
| Consolidations() []*ethpb.SignedConsolidation | |||
| } | |||
There was a problem hiding this comment.
This interface becomes useless now, it can be deleted and simply ReadOnlyBeaconBlockBody
|
|
||
| // ConsolidationRequest is the message from the execution layer to trigger the consolidation of a validator's balance to its balance | ||
| message ConsolidationRequest { | ||
| // Source address of validator which originated the request. |
There was a problem hiding this comment.
Suggested change
| // Source address of validator which originated the request. | |
| // Source address of account which originated the request. |
A validator didn't generate this
terencechain
force-pushed
the
v1.5.0-alpha.3-spec-tests
branch
2 times, most recently
from
799ef08
to
ac7ce7b
Compare
terencechain
force-pushed
the
v1.5.0-alpha.3-spec-tests
branch
from
ac7ce7b
to
afb763d
Compare
prestonvanloon
previously approved these changes
Jun 29, 2024
terencechain
force-pushed
the
v1.5.0-alpha.3-spec-tests
branch
2 times, most recently
from
c2ac727
to
9445570
Compare
terencechain
force-pushed
the
v1.5.0-alpha.3-spec-tests
branch
from
9445570
to
162aa07
Compare
prestonvanloon
approved these changes
Jun 29, 2024
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.