Electra: Move consolidations from beacon block body to execution payload #14152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body to the execution payload header.
1 task
james-prysm
reviewed
Jun 26, 2024
james-prysm
reviewed
Jun 26, 2024
| @@ -1243,7 +1252,6 @@ type executionPayloadHeaderElectra struct { | |||
| } | |||
|
|
|||
| var _ interfaces.ExecutionData = &executionPayloadElectra{} | |||
| var _ interfaces.ExecutionDataElectra = &executionPayloadElectra{} | |||
There was a problem hiding this comment.
we don't need this anymore?
I think this check would still be nice for the ConsolidationRequests function below
There was a problem hiding this comment.
also never mind I found it described up above now
james-prysm
reviewed
Jun 26, 2024
| // source_index=consolidation.source_index, | ||
| // target_index=consolidation.target_index | ||
| // )) | ||
| func ProcessConsolidations(ctx context.Context, st state.BeaconState, cs []*ethpb.SignedConsolidation) error { |
There was a problem hiding this comment.
I guess this will be replaced in the electra operations where the TODO is
james-prysm
approved these changes
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
ethereum/consensus-specs#3775
Which issues(s) does this PR fix?
Other notes for review
t.Skip("Failing until spectests are updated to v1.5.0-alpha.3")