-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electra: new process_consolidation_request
#14163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Jun 28, 2024
@@ -548,7 +548,7 @@ func isCompoundingWithdrawalCredential(creds []byte) bool { | |||
// Check if ``validator`` has a 0x01 or 0x02 prefixed withdrawal credential. | |||
// """ | |||
// return has_compounding_withdrawal_credential(validator) or has_eth1_withdrawal_credential(validator) | |||
func HasExecutionWithdrawalCredentials(v *ethpb.Validator) bool { | |||
func HasExecutionWithdrawalCredentials(v interfaces.WithWithdrawalCredentials) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
james-prysm
reviewed
Jun 28, 2024
james-prysm
reviewed
Jun 28, 2024
james-prysm
reviewed
Jun 28, 2024
prestonvanloon
force-pushed
the
electra-process_consolidation_request
branch
from
June 29, 2024 22:11
332591d
to
275b700
Compare
prestonvanloon
force-pushed
the
electra-process_consolidation_request
branch
from
July 1, 2024 20:17
275b700
to
0e7772a
Compare
james-prysm
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
ethereum/consensus-specs#3775
Which issues(s) does this PR fix?
Other notes for review