Rollback Block During Processing #14554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Oct 28, 2024
| @@ -76,6 +76,7 @@ func (s *Service) postBlockProcess(cfg *postBlockProcessConfig) error { | |||
|
|
|||
| err := s.cfg.ForkChoiceStore.InsertNode(ctx, cfg.postState, cfg.roblock) | |||
| if err != nil { | |||
| s.rollbackBlock(ctx, cfg.roblock.Root()) | |||
There was a problem hiding this comment.
Should we have a unit test triggering this?
potuz
previously approved these changes
Oct 28, 2024
potuz
reviewed
Oct 28, 2024
| require.NoError(t, err) | ||
|
|
||
| // Rollback block insertion into db and caches. | ||
| require.ErrorContains(t, "invalid parent root", service.postBlockProcess(&postBlockProcessConfig{ctx, roblock, [32]byte{}, postState, false})) |
There was a problem hiding this comment.
Could you check for "could not insert block" and "to fork choice store" instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event that there are issues during the processing of a block we rollback the block insertion so as to ensure that the node is not left in an inconsistent state. This will allow the node to be able to process the block quickly again via req/resp .
Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements