Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fix: Update bazel-lib to latest version #14579

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Oct 24, 2024

What type of PR is this?

Fix

What does this PR do? Why is it needed?

Some deb files are now returning a 404. These dependencies are updated to resolve the issue.

Which issues(s) does this PR fix?

There were two issues:

  • bazel-lib was referencing some deb files that were returning a 404.
  • The base images from distroless were returning a 401 unless the host is logged into gcloud/docker. This was a problem for our unprivileged CI runners. To workaround this, I mirrored the manifest to gcr.io/prysmaticlabs. The sha256 did not change.

Other notes for review

Some breaking changes are addressed from rules_oci including the compression on pkg_tar.
Additionally, I've made a note about experiencing a 401 Unauthorized issue when downloading the distroless/cc-debian11 base images.

I revert the proposed changes to update rules_oci. They removed the cURL fallback in v2.0 and now oci_pull completely fails in CI. I've asked for a workaround here: bazel-contrib/rules_oci#456 (comment)

This closed issue is also related: bazel-contrib/rules_oci#292

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@prestonvanloon prestonvanloon changed the title Update bazel-lib to latest version Docker fix: Update bazel-lib, rules_oci to latest version Oct 25, 2024
@prestonvanloon prestonvanloon marked this pull request as ready for review October 25, 2024 01:14
@prestonvanloon prestonvanloon requested a review from a team as a code owner October 25, 2024 01:14
…n11 such that the image is public.

Ran the following command:
gcrane cp 'gcr.io/distroless/cc-debian11@sha256:b82f113425c5b5c714151aaacd8039bc141821cdcd3c65202d42bdf9c43ae60b' gcr.io/prysmaticlabs/distroless/cc-debian11:latest
This backs out commit 64200fb.
@prestonvanloon prestonvanloon changed the title Docker fix: Update bazel-lib, rules_oci to latest version Docker fix: Update bazel-lib to latest version Oct 25, 2024
@prestonvanloon prestonvanloon added this pull request to the merge queue Oct 25, 2024
Merged via the queue into develop with commit 4386c24 Oct 25, 2024
18 checks passed
@prestonvanloon prestonvanloon deleted the update-bazel-lib branch October 25, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants