Light Client: Electra finality branch #14597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested review from
prestonvanloon,
nisdas and
james-prysm
and removed request for
a team
rupam-04
reviewed
Oct 31, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| finalityBranch = fb[:] | ||
| } else { | ||
| b, err := update.NextSyncCommitteeBranch() |
There was a problem hiding this comment.
Suggested change
| b, err := update.NextSyncCommitteeBranch() | |
| scb, err := update.NextSyncCommitteeBranch() |
Lets have this for consistency since you used scb before too
rupam-04
reviewed
Oct 31, 2024
| @@ -243,7 +239,7 @@ func NewLightClientUpdateFromBeaconState( | |||
| return result, nil | |||
| } | |||
|
|
|||
| func CreateDefaultLightClientUpdate(currentSlot primitives.Slot) (interfaces.LightClientUpdate, error) { | |||
| func CreateDefaultLightClientUpdate(currentSlot primitives.Slot, attestedBlock interfaces.ReadOnlySignedBeaconBlock) (interfaces.LightClientUpdate, error) { | |||
There was a problem hiding this comment.
we can pass attestedState here for lesser conflicts with #14585
|
We should be applying the changes in |
rkapka
force-pushed
the
lc-finality-branch
branch
from
e4a8ce1
to
5ffe6fb
Compare
rkapka
force-pushed
the
lc-finality-branch
branch
from
5ffe6fb
to
8248f66
Compare
rkapka
added a commit
that referenced
this pull request
Nov 3, 2024
* extract from lc-p2p branch * generate code * trixy's review * test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.