Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various small things in state-native code #14604

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Fix various small things in state-native code #14604

merged 10 commits into from
Nov 5, 2024

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented Nov 1, 2024 •
edited
Loading

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • To mimic AppendPendingPartialWithdrawal, add a nil check for the value.
  • Remove unused ProcessSyncAggregate alias.
  • Move historicalSummaries that is in the "wrong" spot.
  • Move PendingDeposit.Amount that is in the "wrong" spot.
  • Rename DequeuePartialWithdrawals to DequeuePendingPartialWithdrawals.
  • Remove parentheses from errNotSupported argument.
  • In state_trie.electraFields, move LatestExecutionPayloadHeaderDeneb.

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@jtraglia jtraglia requested a review from a team as a code owner November 1, 2024 19:48
@jtraglia jtraglia changed the title Add nil checks in AppendPending*() functions Fix various small things in state-native code Nov 1, 2024
prestonvanloon
prestonvanloon reviewed Nov 2, 2024
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing CHANGELOG entry. Otherwise LGTM -- thanks!

@james-prysm james-prysm added this pull request to the merge queue Nov 5, 2024
Merged via the queue into prysmaticlabs:develop with commit b87d02e Nov 5, 2024
18 checks passed
@jtraglia jtraglia deleted the add-nil-checks branch November 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon left review comments

@james-prysm james-prysm james-prysm approved these changes

@saolyn saolyn saolyn approved these changes

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtraglia @prestonvanloon @saolyn @james-prysm