Return early blob constructor if not deneb #14605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
return-early-blob-constructor
branch
2 times, most recently
from
9227a99
to
a47f3e0
Compare
terencechain
force-pushed
the
return-early-blob-constructor
branch
from
a47f3e0
to
b0f773a
Compare
rkapka
reviewed
Nov 2, 2024
rkapka
reviewed
Nov 2, 2024
| @@ -194,3 +194,12 @@ func TestReconstructAndBroadcastBlobs(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestReconstructAndBroadcastBlobs_Capella(t *testing.T) { | |||
There was a problem hiding this comment.
This test doesn't really check anything. It will pass even if you reverted your change. You can theoretically check that some error logs are not present, but I am not sure if it's worth it.
Eidt: I found https://github.com/prysmaticlabs/prysm/pull/13809/files#diff-12f8f13acdaf89b149c9a2f153f9348b1eb8ae1cbd1883297a55b8215ff7c47e, you can use this idea if you like it.
There was a problem hiding this comment.
We don't want to log errors or debug. This would create verbose logs for nodes in Capella. The most I'd consider logging is at the trace level, but honestly, I don't think it's worth logging. I'm leaning towards keeping the original state as it is
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
james-prysm
previously approved these changes
Nov 6, 2024
rkapka
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the block is before Deneb, we don’t need to reconstruct the blob sidecar, and in this case, it’s reasonable to return early in the future instead of encountering errors down the line