Rollback Block With Context Deadline #14608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
previously approved these changes
Nov 4, 2024
Comment on lines
79
to
80
| // Do not use parent context in the event it deadlined | ||
| ctx = context.Background() |
There was a problem hiding this comment.
This will lose the span information which breaks tracing on this routine.
Consider doing this:
ctx := trace.NewContext(context.Background(), span)This will create a new context without deadlines and load the metadata from the span on this routine onto that new context.
prestonvanloon
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event there is a context deadline, we will be unable to rollback back a block in the event of an issue in block processing. This is due to the deadlined context preventing the deletion of a block from the db. This can exacerbate any nodes in an inconsistent state and possibly cause them to be completely non-functional . A test has been added for this particular case.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements