Notify about attestations from the pending att queue #14862
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
In the single attestation PR we moved sending the attestation through the notifier's feed to after all validations have been performed (see
beacon-chain/sync/validate_beacon_attestation.go
). This makes sense because we shouldn't notify other parts of the codebase that we received an attestation when that attestation is rejected or ignored. There is one scenario when this is an issue, though. If we receive an attestation which we can't process immediately, we save it to the pending att queue and exit early from the validation function, which means we don't send it through the feed. This is fine, but we need to send it later when we reprocess it at a later time in the pending att queue.Acknowledgements