Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify about attestations from the pending att queue #14862

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Feb 3, 2025

What type of PR is this?

Other

What does this PR do? Why is it needed?

In the single attestation PR we moved sending the attestation through the notifier's feed to after all validations have been performed (see beacon-chain/sync/validate_beacon_attestation.go). This makes sense because we shouldn't notify other parts of the codebase that we received an attestation when that attestation is rejected or ignored. There is one scenario when this is an issue, though. If we receive an attestation which we can't process immediately, we save it to the pending att queue and exit early from the validation function, which means we don't send it through the feed. This is fine, but we need to send it later when we reprocess it at a later time in the pending att queue.

Acknowledgements

@rkapka rkapka requested a review from a team as a code owner February 3, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant