Release 2.3.7

pryv · Oct 3, 2023 · c6d618e · c6d618e
1 parent 7b4ce30
commit c6d618e
Show file tree

Hide file tree

Showing 8 changed files with 2,496 additions and 9,150 deletions.
diff --git a/components/pryv-monitor/package.json b/components/pryv-monitor/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pryv/monitor",
-  "version": "2.3.6",
+  "version": "2.3.7",
   "description": "Extends `pryv` with event-driven notifications for changes on a Pryv.io account",
   "keywords": [
     "Pryv",

diff --git a/components/pryv-socket.io/package.json b/components/pryv-socket.io/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pryv/socket.io",
-  "version": "2.3.6",
+  "version": "2.3.7",
   "description": "Extends `pryv` with Socket.IO transport",
   "keywords": [
     "Pryv",

diff --git a/components/pryv/package.json b/components/pryv/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pryv",
-  "version": "2.3.6",
+  "version": "2.3.7",
   "description": "Pryv JavaScript library",
   "keywords": [
     "Pryv",

diff --git a/components/pryv/src/Service.js b/components/pryv/src/Service.js
@@ -84,7 +84,6 @@ class Service {
   async isDnsLess () {
     const infos = await this.info();
     const hostname = infos.api.split('/')[2];
-    console.log('XXXXX', hostname);
     return !hostname.includes('{username}');
   }
 

diff --git a/components/pryv/test/Service.test.js b/components/pryv/test/Service.test.js
@@ -5,6 +5,8 @@
 /* global describe, it, before, expect, pryv, testData */
 /* eslint-disable no-unused-expressions */
 
+const isNode = (typeof window === 'undefined');
+
 describe('Service', function () {
   before(async function () {
     this.timeout(5000);
@@ -76,11 +78,18 @@ describe('Service', function () {
       this.timeout(5000);
       const pryvService = new pryv.Service(testData.serviceInfoUrl);
       // check if username is in path or domain
-      if (await pryvService.isDnsLess()) {
-        await expect(pryvService.login('wrong-username', 'bobby', 'jslib-test')).to.be.rejectedWith('Unknown user "wrong-username"');
-      } else {
-        await expect(pryvService.login('wrong-username', 'bobby', 'jslib-test')).to.be.rejectedWith('getaddrinfo ENOTFOUND wrong');
+      try {
+        await pryvService.login('wrong-username', 'bobby', 'jslib-test');
+      } catch (error) {
+        let errorMessage = isNode ? 'getaddrinfo ENOTFOUND wrong' : 'Request has been terminated';
+        if (await pryvService.isDnsLess()) {
+          errorMessage = 'Unknown user "wrong-username"';
+        }
+        const receivedMessage = error.message.slice(0, errorMessage.length);
+        expect(receivedMessage).to.be.equal(errorMessage);
+        return;
       }
+      throw new Error('Should fail');
     });
   });
 });