Merged
Conversation
87d1bce to
90fea48
Compare
0610ca2 to
5e97277
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajusted the sjis encoder/decoder to match
81 40with space, and81 44with period.Added logic+UI to handle icon.sys' linebreak.
Refactored icon_sys_viewer::file_select() and title_cfg_viewer::value_select() into a unified component.
The component returns the Response of the underlying text field.
Add warning messages to icon.sys tab to warn against lengthy title/filenames.
Improve icon.sys UI alignment and standardize toolbar sizes across all tabs.