feature: tighten return types of config helper by using dynamic analysis #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-feek
force-pushed
the
config-dynamic-analysis
branch
from
3ecb761
to
cc5203b
Compare
|
Going to leave this open while i ponder how types might change depending on environment configuration |
|
note: always add the type of the default value to the return union type |
|
I made a preliminary PR to at least correct the basic typehint of |
alies-dev
added
release:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should tighten the return types of the
confighelper to be the actual resolved type at runtime, rather thanRepository|mixed.This should result in proper types being returned, and reducing the number of
PossiblyInvalidCastthat psalm emits after using theconfighelper