add system brightness toggle for dark mode #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a new toggle to use system brightness for dark mode.
Currently the application will fallback to the system dark mode on startup, not caring for the value the user set in the previous session.
The user will have now a checkbox (on by default) to use the system dark mode or set manually dark/light mode, persisting the application restart.
This is my first time using QT so I tried to stick to the existing features as close as possible.
The idea for this feature stems from my brother and I's experience using the application on Windows 10/11 where it starts in light mode despite the system using dark mode. There is a need to look for the root cause but I do not have the necessary skills to do so.