Open
Conversation
Sarah Smulligan (Smullz622)
requested review from
Alex Kiessling (ajkiessl),
Grant Allen (granta03) and
Jesse LE (jlandiseigsti)
| class ConcurrentJobsError < StandardError; end | ||
|
|
||
| before_perform :prevent_concurrent_jobs, :integration_start, :clear_tmp_files, :delete_all_data | ||
| before_perform :prevent_concurrent_jobs, :integration_start, :delete_all_data |
Contributor
There was a problem hiding this comment.
We might want to add before_perform :clear_tmp_files directly to the Jobs we intend to keep running synchronously. Just to make sure that directory is cleared before those run.
| @@ -0,0 +1,7 @@ | |||
| Sidekiq.configure_server do |config| | |||
| config.redis = { url: ENV.fetch('SIDEKIQ_REDIS_URL') { 'redis://localhost:6379/0' } } | |||
Contributor
There was a problem hiding this comment.
We'll need to configure this variable in k8s when the redis instance is set up.
Contributor
|
We'll need to get a redis and sidekiq instance set up in k8s to get this to work in QA/prod. I have a comment in the issue here: #120 (comment) about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up sidekiq and changes how create user integration works so it runs as a background job.
This technically works at this point, but there are some improvements I'd like to make regarding how we handle files (perform_later doesn't accept all of the same arguments types that perform_now does which causes some problems here). I will document further in a future ticket, but I wanted to get a workable solution out there so Nicole can use this tool.