Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement chunk size argument and refactor mbuffer command generation #204

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Implement chunk size argument and refactor mbuffer command generation #204

merged 2 commits into from
Oct 16, 2023

Conversation

P-EB
Copy link
Contributor

@P-EB P-EB commented Jul 18, 2023

Would fix #203

@psy0rz
Copy link
Owner

psy0rz commented Jul 24, 2023

looks fine, but could you rename it to --buffer-chunk-size? (or something that starts with --buffer-)

@coveralls
Copy link

Coverage Status

coverage: 86.354% (-0.1%) from 86.449% when pulling 529c1bc on P-EB:feature/chunk-size into ee1d17b on psy0rz:master.

@P-EB
Copy link
Contributor Author

P-EB commented Jul 26, 2023

Sure! Be my guest!

@P-EB
Copy link
Contributor Author

P-EB commented Oct 3, 2023

(done)

@psy0rz
Copy link
Owner

psy0rz commented Oct 16, 2023

thanks!

@psy0rz psy0rz merged commit 843b87f into psy0rz:master Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request - Allow one to change mbuffer chunk size.
3 participants
@P-EB @psy0rz @coveralls