-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sungrow SH5k-20 #4
Open
tjhowse
wants to merge
20
commits into
ptarcher:master
Choose a base branch
from
tjhowse:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder of the integer they depict.
…ly interpret signed values.
I have drastically improved the performance of this interface by hard-wiring an ethernet connection to the inverter rather than using the wifi dongle. Modbus communication failures have completely gone away. It's quite likely the modbus re-connection change I made in this branch are unnecessary. |
@ptarcher Ping! Are you alive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a fair few modifications to how the interface works. I've added the registers that the SH5k-20 holds, as well as added a type key to the register map per register, to allow for translation to signed values before publishing to MQTT.
I slightly reworked how modbus reconnects are handled.
I'm still not entirely happy with this interface. Sometimes the inverter stops responding to modbus requests for a while. I'm not sure if this is a timing issue, or whether the inverter doesn't properly implement modbus, or what. It's a little annoying.
In any case, this is a better starting point for someone wanting to get data from an SH5k-20 using pvstats than not having it at all.
I also stored the registers using integer keys, not strings, since they sort correctly. When adding registers in the 13000 range they sorted to before the registers in the 5000 range, causing difficulties.