When BOX64_VERSION is set, just print the version and exit #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set, box64 will only print its version and then exit. This option is analogous to QEMU_VERSION used by binfmt_misc emulation of qemu-user. Its purpose is the same: provide a way to soft-disable binfmt_misc emulation as well as for identifying box64 as the registered binfmt_misc emulator. This commit enables adding support for box64 to the arch-test utility. With this change, arch-test is able to soft-disable box64 as the x86_64 emulator in the same way as it does this for qemu and wine already. Without this change, arch-test will report an architecture as natively executable by the processor, disregarding that it actually gets emulated by box64. Furthermore, this commit enables identifying box64 as the currently registered emulator for x86_64. This way, applications that know that their emulation requirements cannot work with box64 can add a check to find out that it is box64 doing the emulation and are able to print a helpful error message. Closes: ptitSeb#1237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set, box64 will only print its version and then exit. This option is analogous to QEMU_VERSION used by binfmt_misc emulation of qemu-user. Its purpose is the same: provide a way to soft-disable binfmt_misc emulation as well as for identifying box64 as the registered binfmt_misc emulator.
This commit enables adding support for box64 to the arch-test utility. With this change, arch-test is able to soft-disable box64 as the x86_64 emulator in the same way as it does this for qemu and wine already. Without this change, arch-test will report an architecture as natively executable by the processor, disregarding that it actually gets emulated by box64.
Furthermore, this commit enables identifying box64 as the currently registered emulator for x86_64. This way, applications that know that their emulation requirements cannot work with box64 can add a check to find out that it is box64 doing the emulation and are able to print a helpful error message.
Closes: #1237