New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ActiveProfiles in test classes and removed secret keys #158

Closed

thomedw wants to merge 1 commit into main from secret

+14 −3

src/main/resources/application.properties

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,14 +4,12 @@ keycloak.auth-server-url = https://auth.banyuwangikab.go.id @@
     keycloak.ssl-required = external
     keycloak.resource =banyuwangi-webapp
     keycloak.verify-token-audience=false
-    keycloak.credentials.secret =fxraDjJMINZSunzgmom1GtrALENPN7sn
     keycloak.use-resource-role-mappings = false
     spring.security.oauth2.client.provider.banyuwangi.issuer-uri=https://auth.banyuwangikab.go.id/realms/banyuwangi
     spring.security.oauth2.client.provider.banyuwangi-test.issuer-uri=https://auth.banyuwangikab.go.id/realms/banyuwangi
     spring.security.oauth2.client.registration.banyuwangi-test.client-id=banyuwangi-test
-    spring.security.oauth2.client.registration.banyuwangi-test.client-secret=MZASrIBdZrMSViBBgLhOCnOeatyiDYPD
     spring.security.oauth2.client.registration.banyuwangi-test.authorization-grant-type=client_credentials
     spring.rabbitmq.addresses=localhost:5672
@@ Expand Down Expand Up / @@ -73,7 +71,6 @@ dashboard.app.fcmRateLimit=4 @@
     streaming.baseUrl=https://stream-ai.banyuwangikab.go.id
     streaming.server=https://stream-ai.banyuwangikab.go.id
-    streaming.streamingToken=9f8c835e-1896-4f54-b544-29d2a6df802a
     gcp.firebase.serviceAccount=classpath:banyuwangi-dashboard-firebase-adminsdk.json

src/test/kotlin/com/katalisindonesia/banyuwangi/controller/AlarmControllerTest.kt

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
     package com.katalisindonesia.banyuwangi.controller
     import com.katalisindonesia.banyuwangi.repo.AlarmRepo
     import com.katalisindonesia.banyuwangi.security.TokenManager
@@ Expand All / @@ -9,11 +9,13 @@ @@
     import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
     import org.springframework.boot.test.context.SpringBootTest
     import org.springframework.http.MediaType
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.get
     @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class AlarmControllerTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val alarmRepo: AlarmRepo,
@@ Expand Down @@

src/test/kotlin/com/katalisindonesia/banyuwangi/controller/CameraControllerTest.kt

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
     package com.katalisindonesia.banyuwangi.controller
     import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
     import com.katalisindonesia.banyuwangi.model.Camera
@@ Expand All / @@ -11,13 +11,15 @@ @@
     import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
     import org.springframework.boot.test.context.SpringBootTest
     import org.springframework.http.MediaType
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.get
     import org.springframework.test.web.servlet.post
     import java.util.UUID
     @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class CameraControllerTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val tokenManager: TokenManager,
@@ Expand Down @@

src/test/kotlin/com/katalisindonesia/banyuwangi/controller/ChartControllerIntegrationTest.kt

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
     package com.katalisindonesia.banyuwangi.controller
     import com.katalisindonesia.banyuwangi.model.DetectionType
     import com.katalisindonesia.banyuwangi.security.TokenManager
@@ Expand All / @@ -7,6 +7,7 @@ @@
     import org.springframework.beans.factory.annotation.Autowired
     import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
     import org.springframework.boot.test.context.SpringBootTest
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.context.junit.jupiter.SpringExtension
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.get
@@ Expand All / @@ -20,6 +21,7 @@ @@
     @ExtendWith(SpringExtension::class)
     @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class ChartControllerIntegrationTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val tokenManager: TokenManager,
@@ Expand Down @@

src/test/kotlin/com/katalisindonesia/banyuwangi/controller/DetectionControllerTest.kt

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
     package com.katalisindonesia.banyuwangi.controller
     import com.katalisindonesia.banyuwangi.consumer.BoundingBox
     import com.katalisindonesia.banyuwangi.consumer.Corners
@@ Expand All / @@ -22,6 +22,7 @@ @@
     import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
     import org.springframework.boot.test.context.SpringBootTest
     import org.springframework.data.domain.Sort.Direction
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.context.junit.jupiter.SpringExtension
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.get
@@ Expand All / @@ -35,6 +36,7 @@ @@
     @ExtendWith(SpringExtension::class)
     @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class DetectionControllerTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val tokenManager: TokenManager,
@@ Expand Down @@

src/test/kotlin/com/katalisindonesia/banyuwangi/controller/FirebaseControllerTest.kt

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
     package com.katalisindonesia.banyuwangi.controller
     import com.katalisindonesia.banyuwangi.repo.FcmTokenRepo
     import com.katalisindonesia.banyuwangi.security.TokenManager
@@ Expand All / @@ -10,6 +10,7 @@ @@
     import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
     import org.springframework.boot.test.context.SpringBootTest
     import org.springframework.http.MediaType
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.context.junit.jupiter.SpringExtension
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.delete
@@ Expand All / @@ -18,6 +19,7 @@ @@
     @ExtendWith(SpringExtension::class)
     @SpringBootTest
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class FirebaseControllerTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val tokenManager: TokenManager,
@@ Expand Down @@

src/test/kotlin/com/katalisindonesia/banyuwangi/controller/LiveViewControllerTest.kt

-Original file line number
+Diff line change
@@ -1,4 +1,4 @@
     package com.katalisindonesia.banyuwangi.controller
     import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
     import com.katalisindonesia.banyuwangi.consumer.MessagingProperties
@@ Expand All / @@ -17,6 +17,7 @@ @@
     import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
     import org.springframework.boot.test.context.SpringBootTest
     import org.springframework.http.MediaType
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.context.junit.jupiter.SpringExtension
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.get
@@ Expand All / @@ -26,6 +27,7 @@ @@
     @ExtendWith(SpringExtension::class)
     @SpringBootTest
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class LiveViewControllerTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val tokenManager: TokenManager,
@@ Expand Down @@

src/test/kotlin/com/katalisindonesia/imageserver/controller/ImageControllerTest.kt

-Original file line number
+Diff line change
@@ Expand Up @@
     import org.springframework.boot.test.context.SpringBootTest
     import org.springframework.core.io.ClassPathResource
     import org.springframework.http.MediaType
+    import org.springframework.test.context.ActiveProfiles
     import org.springframework.test.context.junit.jupiter.SpringExtension
     import org.springframework.test.web.servlet.MockMvc
     import org.springframework.test.web.servlet.get
@@ Expand All / @@ -30,6 +31,7 @@ import java.util.UUID @@
         classes = [BanyuwangiCoreApplication::class]
     )
     @AutoConfigureMockMvc
+    @ActiveProfiles("secret", "default")
     class ImageControllerTest(
         @Autowired private val mockMvc: MockMvc,
         @Autowired private val imageProperties: ImageProperties,
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ActiveProfiles in test classes and removed secret keys #158

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report

GitHub Actions / JUnit Test Report