fix: incorrect detection of EP moves when making moves#211
Open
ptsouchlos wants to merge 21 commits intomainfrom
Open
fix: incorrect detection of EP moves when making moves#211ptsouchlos wants to merge 21 commits intomainfrom
ptsouchlos wants to merge 21 commits intomainfrom
Conversation
bench: 1049188
bench: 1049188
Added failing unit test for the case where an en passant square is currently incorrectly recognized.
bench: 1084772
bench: 1084772
bench: 1084772
bench: 1015937
bench: 1015937
bench: 1015937
bench: 1015937
Implement a "line bitboard" function imitating what is done in stockfish. This is used as part of the fix for properly detecting legal EP squares when move making.
This largely follows the same logic as the fix/patch in stockfish, including the latest changes and simplification (see official-stockfish/Stockfish@2321cf2) bench: 1084774
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 91.04% 91.65% +0.60%
==========================================
Files 40 40
Lines 7136 7321 +185
==========================================
+ Hits 6497 6710 +213
+ Misses 639 611 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cleaned up code that fixes the PV bug and tried to add better comments for my future self since I have a smooth brain. bench: 1084774
bench: 1084774
bench: 1084774
We'll add this back in a follow up PR where we'll factor it out of the move generator. For now, it's not needed (or used) in this branch. bench: 1084774
ptsouchlos
force-pushed
the
fix/pv-move-crashes
branch
from
e40e0be to
3baf143
Compare
bench: 1084774
bench: 1084774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bitboard::iter(), needed for [CHORE] MigrateBitboarditeration from while loop toBitboard::iter()#201boardmodule as we putmove_makingin it's own folder.Bitboardmore_than_one()function (yoinked from Stockfish)empty()function for convenience.attacksmoduleattacks::for_piecetofor_piece_on_squareand added a newfor_piecethat gets attacks for all squares.rays::line()function (yoinked from Stockfish)bench: 1084774