-
Notifications
You must be signed in to change notification settings - Fork 2
Fix/version #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kooksee
wants to merge
24
commits into
release/0.6
Choose a base branch
from
fix/version
base: release/0.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/version #50
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5e05089
chore: set version from build info main version
kooksee 3b2b861
feat: add embedded version string and getter
kooksee e947b5d
refactor(log): improve logger copying and deprecate WithEvent
kooksee 7c0a437
fix: barry quick fix, 2025-09-08 01:09:57
kooksee 54bd373
fix: barry quick fix, 2025-09-12 23:58:36
kooksee ebc6fb5
refactor(vars): replace expvar with atomic types and fix Result logic
kooksee a9805a0
fix: barry quick fix, 2025-09-13 09:54:55
kooksee 7726faf
refactor: remove deprecated Result function
kooksee 0a8a1b6
chore: quick update fix/version at 2025-09-15 23:52:18
kooksee 5030e67
chore: quick update fix/version at 2025-09-16 18:31:37
kooksee b606183
fix: barry quick fix, 2025-09-16 20:42:29
kooksee 82d51f9
fix: barry quick fix, 2025-09-16 20:51:06
kooksee 4aee6c0
chore: quick update fix/version at 2025-09-16 22:00:15
kooksee 5921f06
chore: quick update fix/version at 2025-09-17 17:07:01
kooksee 7c14e8e
Merge branch 'fix/version' of github.com:pubgo/funk into fix/version
kooksee 4781f16
chore: quick update fix/version at 2025-09-17 22:36:02
kooksee 42e184c
chore: quick update fix/version at 2025-09-18 14:28:25
kooksee bc28ade
Merge branch 'fix/version' of github.com:pubgo/funk into fix/version
kooksee 60706fd
chore: quick update fix/version at 2025-09-19 20:56:03
kooksee 47c1cd2
chore: quick update fix/version at 2025-09-22 11:25:30
kooksee 5f3032e
chore: quick update fix/version at 2025-09-22 11:32:08
kooksee db141c1
chore: quick update fix/version at 2025-09-23 13:34:47
kooksee 34a5ee7
Merge branch 'fix/version' of github.com:pubgo/funk into fix/version
kooksee 83b32e5
chore: quick update fix/version at 2025-09-23 23:13:48
kooksee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
v0.5.69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message "a,b not equal" is not very descriptive. When an equality check fails, it's very helpful for debugging to see the difference between the two values. The
cmp.Diff
function is great for this. Also, thepp.Println
calls print to standard output, but their output is not part of the error that gets logged or panicked. Including the diff in the error message would make debugging much easier.