CollectionData with minimal props, name and symbol, all others are optional. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitruong
force-pushed
the
fix_collection_data
branch
2 times, most recently
from
ba74d33 to
5ec9c46
Compare
taitruong
commented
Nov 21, 2023
| @@ -927,6 +927,7 @@ fn test_do_instantiate_and_mint() { | |||
| assert_eq!(base_owner, owner); | |||
| } | |||
| // test case: instantiate cw721 with CustomClassData (without owner, name, and symbol) | |||
| // as a result instantiated collection on target chain will use class id for name and symbol | |||
There was a problem hiding this comment.
This is the test, in case custom data is passed to target chain (e.g. SgCollectionData). So target chain wont have name and symbol.
shanev
approved these changes
Nov 21, 2023
humanalgorithm
approved these changes
Nov 21, 2023
…props are optional
… additional custom data
taitruong
force-pushed
the
fix_collection_data
branch
from
5ec9c46 to
bf2e219
Compare
taitruong
changed the title
jhernandezb
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing CollectionData is now more lenient/less restrictive. Incoming class data is checked whether it has name and symbol, which is then used for instantiated, escrowed nft contract.
Custom contracts may attach additional props - like
sg-ics721with collection info to class data.ics721is properly parsing it and only check for name and symbol.