new CW721_ADMIN store #81
Conversation
taitruong
force-pushed
the
cw721_admin
branch
from
0089c2a to
04fd6a8
Compare
taitruong
requested review from
Art3miX,
shanev,
jhernandezb and
humanalgorithm
and removed request for
Art3miX,
shanev,
jhernandezb and
humanalgorithm
|
pls review @humanalgorithm @shanev @jhernandezb |
| @@ -506,6 +529,19 @@ where | |||
| .add_attribute( | |||
| "cw721_base_code_id", | |||
| cw721_base_code_id.map_or_else(|| "none".to_string(), |or| or.to_string()), | |||
| ) | |||
| .add_attribute( | |||
There was a problem hiding this comment.
Can you explain what this line is doing?
There was a problem hiding this comment.
Here cw721_base_code_id is of type Option<u64>. In response it just say "none" is provided - instead of returning an empty string.
There was a problem hiding this comment.
My question here is why do we have the plaintext "none" instead of an actual None?
There was a problem hiding this comment.
Attribute must be a string, that's why we need to convert all these data.
packages/ics721/src/state.rs
Outdated
| @@ -38,6 +38,8 @@ pub const INCOMING_CLASS_TOKEN_TO_CHANNEL: Map<(ClassId, TokenId), String> = Map | |||
| /// is `None`) is stored in this map. When the token is returned to | |||
| /// it's source chain, the metadata is removed from the map. | |||
| pub const TOKEN_METADATA: Map<(ClassId, TokenId), Option<Binary>> = Map::new("j"); | |||
| /// The admin address for instantiating new cw721 contracts. In case of None, contract is immutable. | |||
| pub const CW721_ADMIN: Item<Option<Addr>> = Item::new("l"); | |||
There was a problem hiding this comment.
Main point of the PR is here
There was a problem hiding this comment.
Per discussion, this name doesn't really describe what's going on. Please rename to something like ADMIN_USED_FOR_CW721.
The point of this store is to *copy the admin here when instantiating new cw721 contracts
taitruong
requested review from
jhernandezb and
tasiov
and removed request for
jhernandezb and
tasiov
new store allows to provide e.g.
Some(addr)orNonewhich will be used for setting admin during instantiation of cw721.