Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The graph div should be made responsive. #110

Closed
5 tasks
sidntrivedi012 opened this issue Jul 21, 2019 · 22 comments
Closed
5 tasks

The graph div should be made responsive. #110

sidntrivedi012 opened this issue Jul 21, 2019 · 22 comments

Comments

@sidntrivedi012
Copy link
Member

sidntrivedi012 commented Jul 21, 2019

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

In spectral-workbench.js for capture part we have set the graph width to 1024px here : https://github.com/publiclab/spectral-workbench.js/blob/main/examples/capture/capture.css. But it won't work properly for every window size. We need to set the width using the media query to make it work for different screen sizes.

This is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open-source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@sidntrivedi012

This comment has been minimized.

@dimkov41

This comment has been minimized.

@sidntrivedi012

This comment has been minimized.

@dimkov41

This comment has been minimized.

@sidntrivedi012

This comment has been minimized.

@starkblaze01

This comment has been minimized.

@sidntrivedi012

This comment has been minimized.

@dimkov41

This comment has been minimized.

@DevLukill-pl

This comment has been minimized.

@sidntrivedi012

This comment has been minimized.

@DevLukill-pl

This comment has been minimized.

@sidntrivedi012

This comment has been minimized.

@DevLukill-pl

This comment has been minimized.

@discombobulateme

This comment has been minimized.

@sidntrivedi012

This comment has been minimized.

@starkblaze01
Copy link
Member

Uploaded on GCI dashboard

@SidharthBansal
Copy link
Member

Please hide stale comments asap.
PUBLISHED ON GCI DASHBOARD

@sashadev-sky
Copy link
Member

sashadev-sky commented Nov 18, 2019

@SidharthBansal @starkblaze01 @sidntrivedi012 I am confused. There is no actual issue to solve written in the issue body? I was pretty sure we were meant to have both Github issue and Dashboard task updated with at least the prompt?

@starkblaze01
Copy link
Member

Hi, @sashadev-sky. I have updated the comment. Is it fine now?

@ghost
Copy link

ghost commented Dec 11, 2019

Has anybody claimed this task yet? I would be willing to take this task for GCI.

@starkblaze01
Copy link
Member

Hi, @EC3x1903 thanks for your interest. But this task has already been taken and being solved here #149.

@starkblaze01
Copy link
Member

Merged #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants