-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive graph in capture example #149
Conversation
Thanks for opening this pull request! |
Welcome to Public Labs @symt! If you haven't already, be sure to check out the welcoming post at publiclab/plots2#6808 😄 You can also come to chat with us on gitter! The changes look great, should be ready to merge now! Glad to have you here 🎉 |
examples/capture/capture.css
Outdated
@@ -42,3 +42,9 @@ hr { | |||
height: 200px; | |||
margin: 10px 0px; | |||
} | |||
|
|||
@media only screen and (max-width: 1300px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @symt Thanks for opening the PR. Things are great so far but you have to add some changes. You have to set different widths for different standard screen sizes. And add gifs for it. Please so open the developer console in the gifs to make sure things are working fine. You can screen sizes for different ranges. Like for up to max-width: 480px
, max-width: 992px
and max-width: 1382px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something like this what you're looking for? I'm not sure if the CORS error is relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use Bootstrap layout classes to manage this in a standarized way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @symt changes look great. Can you add gifs showing different screen sizes on the browser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats on merging your first pull request! 🙌🎉⚡️ |
Super! Great work!!! Thank you! |
In response to #110 (for gci).
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!
What it looks like: https://imgur.com/a/l8zFo9M
I'm unsure if that is the correct "item" to be looking at for the change. If it isn't, please tell me and I'll modify the query to fit the correct standard.