-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo #114
base: main
Are you sure you want to change the base?
Fix typo #114
Conversation
Thanks for opening this pull request! |
Hey @Lionel-Stewart , thanks for sending the PR and reaching out. We appreciate it a lot. 🎉 Can you change /cc: @jywarren Thanks 🙂 |
That's fine, I'll start working on it right now. |
Alright, that should do it, let me know if you could use anymore help. |
LGTM. @jywarren , Should we merge it now or after implementing the capture interface on Safari Browser for Mac/iOS ? Thanks again @Lionel-Stewart . Yes, we have a lot of issues here at our Community Toolbox - https://code.publiclab.org . Do help out wherever you can. All the best 👍 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Lionel-Stewart, thanks for opening PR. It would be great if could mark the satisfying boxes checked.
Also, mentioning only Safari on iOS would do, as conventionally we have done the same for Chrome. And yes, @sidntrivedi012 we merge it after implementing it for iOS.
Sure @starkblaze01 👍 |
@starkblaze01 My bad, didn't know about those checkboxes. I marked the ones I think are satisfied, though this is my first contribution so I'm not entirely sure. |
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!