Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo #114

wants to merge 2 commits into from

Conversation

Lionel-Stewart
Copy link

@Lionel-Stewart Lionel-Stewart commented Jul 23, 2019

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- see README.md for how to run them
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@welcome
Copy link

welcome bot commented Jul 23, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@sidntrivedi012 sidntrivedi012 mentioned this pull request Jul 24, 2019
5 tasks
@sidntrivedi012
Copy link
Member

sidntrivedi012 commented Jul 24, 2019

Hey @Lionel-Stewart , thanks for sending the PR and reaching out. We appreciate it a lot. 🎉

Can you change Browser to Safari Browser and the link to https://www.apple.com/in/safari/ ? I just came to know that we used to support Bowser earlier but now, we are aiming to get it working for the native browser i.e. Safari of iOS.

/cc: @jywarren

Thanks 🙂

@Lionel-Stewart
Copy link
Author

That's fine, I'll start working on it right now.

@Lionel-Stewart
Copy link
Author

Alright, that should do it, let me know if you could use anymore help.

@sidntrivedi012
Copy link
Member

sidntrivedi012 commented Jul 26, 2019

LGTM.

@jywarren , Should we merge it now or after implementing the capture interface on Safari Browser for Mac/iOS ?

Thanks again @Lionel-Stewart . Yes, we have a lot of issues here at our Community Toolbox - https://code.publiclab.org . Do help out wherever you can.

All the best 👍 💯

Copy link
Member

@starkblaze01 starkblaze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Lionel-Stewart, thanks for opening PR. It would be great if could mark the satisfying boxes checked.
Also, mentioning only Safari on iOS would do, as conventionally we have done the same for Chrome. And yes, @sidntrivedi012 we merge it after implementing it for iOS.

@sidntrivedi012
Copy link
Member

Sure @starkblaze01 👍

@Lionel-Stewart
Copy link
Author

@starkblaze01 My bad, didn't know about those checkboxes. I marked the ones I think are satisfied, though this is my first contribution so I'm not entirely sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants