Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary If-Match ETag support for User and Channel #432

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

wkal-pubnub
Copy link
Contributor

@wkal-pubnub wkal-pubnub commented Jan 21, 2025

feat: A new optional parameter ifMatchesEtag is added to setUUIDMetadata and setChannelMetadata. When provided, the server compares the argument value with the ETag on the server and if they don't match a HTTP 412 error is returned.

Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditions can be written shorter, but it is good for now :)

@wkal-pubnub wkal-pubnub marked this pull request as ready for review January 21, 2025 14:28
@wkal-pubnub
Copy link
Contributor Author

@pubnub-release-bot release

@parfeon parfeon merged commit f5f9670 into master Jan 21, 2025
7 checks passed
@parfeon parfeon deleted the wkal/etag_support branch January 21, 2025 14:53
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants