Added gzipped JS build for CDN with JS core bundled #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
jakub-grzesiowski,
jguz-pubnub and
parfeon
as code owners
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Add AWS CLI configuration and upload to CDN
parfeon
requested changes
Dec 8, 2025
js-chat/rollup.config.mjs
Outdated
| input: "./main.mjs", | ||
| external: [], // Bundle everything | ||
| output: { | ||
| file: `dist/pubnub-chat.${pkg.version}.js`, |
Contributor
There was a problem hiding this comment.
Can we move both bundles to a separate folder?
Separate folder like: upload not related to the NPM distribution + less chances to drag something unwanted to the CDN.
So far I've configured CDN upload artifacts location to the: js-chat/upload/*.js
Contributor
Author
There was a problem hiding this comment.
Ok, I will move it.
js-chat/rollup.config.mjs
Outdated
| browser: true, | ||
| preferBuiltins: false | ||
| }), | ||
| commonjs() |
Contributor
There was a problem hiding this comment.
If it possible, can we compress (gzip) both bundles with @rollup/plugin-typescript?
In JS SDK it goes after last plugin, to work on the resulting bundle like this:
gzipPlugin({ fileName: '' }),imported it with require:
const gzipPlugin = require('rollup-plugin-gzip').default;
Contributor
Author
There was a problem hiding this comment.
I will compress them.
marcin-cebo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.