-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a template for our simplest nginx configs #4231
Conversation
ae980e9
to
ea99ad3
Compare
A quick look at a few config files uncovers a few differences among sites. Known needed changes:
With these changes done, we can try using the template for these sites:
Once the changes are ready, we can put the vars in place and create the templated files in |
Add a variable for the health check page (see Drupal sites for examples). |
Current CI failure is:
|
68efd90
to
ed149a2
Compare
aae6e9c
to
a814abe
Compare
Co-authored-by: Francis Kayiwa <kayiwa@users.noreply.github.com> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com> Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com> Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com> Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com> Co-authored-by: Vickie Karasic <vickiekarasic@users.noreply.github.com>
8344c8c
to
c793bd0
Compare
Closing in favor of #4397 |
DRAFT ONLY - includes changes for testing that must not be merged.
This approach would convert a majority of our nginx config files to variables that run through a template. Currently addresses our two most common use cases:
location
definitionlocation
definition that are restricted to the VPN