Skip to content

Conversation

Alvin-FA
Copy link

@Alvin-FA Alvin-FA commented Apr 11, 2025

For demux, we can check the connectivity before routing, this can improve transmission efficiency. The more there are such case that connectivity[i][j] == 0 between slave_port[i] and mst_port[j], the better the improvement effect will be. Because the unnecessary arbitrations have been reduced, this accelerates the correct access response. At the same time, ensure that there is a dedicated port to receive decode errors as before.

@Alvin-FA Alvin-FA closed this Apr 11, 2025
@Alvin-FA Alvin-FA reopened this Apr 11, 2025
@Alvin-FA Alvin-FA closed this Apr 11, 2025
@Alvin-FA Alvin-FA reopened this Apr 11, 2025
@Alvin-FA Alvin-FA changed the title [optimize] determine the connection relationship before routing [optimize] judge the connection relationship before routing Apr 11, 2025
@Alvin-FA Alvin-FA changed the title [optimize] judge the connection relationship before routing axi_xbar_unmuxed: judge the connection relationship before routing Apr 11, 2025
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an interesting improvement! I have one concern: What happens if a specific port has en_default_mst_port_i set and the default_mst_port_i for that slv_port is not connected? Let's double-check that we can handle this scenario correctly as well.

@Alvin-FA Alvin-FA closed this Apr 25, 2025
@Alvin-FA Alvin-FA reopened this Apr 25, 2025
@Alvin-FA
Copy link
Author

This looks like an interesting improvement! I have one concern: What happens if a specific port has en_default_mst_port_i set and the default_mst_port_i for that slv_port is not connected? Let's double-check that we can handle this scenario correctly as well.

I think this scenario belongs to a configuration file error. If someone use en_default_mst_port_i and default_mst_port_i, he/she should ensure the connectivity correctly. Unfortunately, if this scenario really occurs, we can only ensure that the route to the instantiation of axi_err_slv module to avoid deadlock.

@micprog
Copy link
Member

micprog commented Apr 25, 2025

This looks like an interesting improvement! I have one concern: What happens if a specific port has en_default_mst_port_i set and the default_mst_port_i for that slv_port is not connected? Let's double-check that we can handle this scenario correctly as well.

I think this scenario belongs to a configuration file error. If someone use en_default_mst_port_i and default_mst_port_i, he/she should ensure the connectivity correctly. Unfortunately, if this scenario really occurs, we can only ensure that the route to the instantiation of axi_err_slv module to avoid deadlock.

I agree, if this occurs, then whoever set this up made a mistake. Nonetheless, we can still support this case, maybe with a parameter as an option to disable it?

I think we could directly handle this by setting the corresponding default_idx_i of the addr_decode modules as follows:

-      .default_idx_i ( default_mst_port_i[i] )
+      .default_idx_i ( Connectivity[i][default_mst_port_i[i]] ? default_mst_port_i[i] : mst_port_idx_t'(Cfg.NoMstPorts) )

There may be some PPA implications in non-static cases, but this approach should still properly return DECERR for routing to an unconnected region.

@Alvin-FA
Copy link
Author

This looks like an interesting improvement! I have one concern: What happens if a specific port has en_default_mst_port_i set and the default_mst_port_i for that slv_port is not connected? Let's double-check that we can handle this scenario correctly as well.

I think this scenario belongs to a configuration file error. If someone use en_default_mst_port_i and default_mst_port_i, he/she should ensure the connectivity correctly. Unfortunately, if this scenario really occurs, we can only ensure that the route to the instantiation of axi_err_slv module to avoid deadlock.

I agree, if this occurs, then whoever set this up made a mistake. Nonetheless, we can still support this case, maybe with a parameter as an option to disable it?

I think we could directly handle this by setting the corresponding default_idx_i of the addr_decode modules as follows:

-      .default_idx_i ( default_mst_port_i[i] )
+      .default_idx_i ( Connectivity[i][default_mst_port_i[i]] ? default_mst_port_i[i] : mst_port_idx_t'(Cfg.NoMstPorts) )

There may be some PPA implications in non-static cases, but this approach should still properly return DECERR for routing to an unconnected region.

Excellent! It is a very ingenious solution.

Alvin-FA and others added 3 commits April 26, 2025 16:12
…ove transmission efficiency and reduce the consumption of hardware resources
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants