-
Notifications
You must be signed in to change notification settings - Fork 315
axi_xbar_unmuxed: judge the connection relationship before routing #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an interesting improvement! I have one concern: What happens if a specific port has en_default_mst_port_i
set and the default_mst_port_i
for that slv_port is not connected? Let's double-check that we can handle this scenario correctly as well.
I think this scenario belongs to a configuration file error. If someone use en_default_mst_port_i and default_mst_port_i, he/she should ensure the connectivity correctly. Unfortunately, if this scenario really occurs, we can only ensure that the route to the instantiation of axi_err_slv module to avoid deadlock. |
I agree, if this occurs, then whoever set this up made a mistake. Nonetheless, we can still support this case, maybe with a parameter as an option to disable it? I think we could directly handle this by setting the corresponding - .default_idx_i ( default_mst_port_i[i] )
+ .default_idx_i ( Connectivity[i][default_mst_port_i[i]] ? default_mst_port_i[i] : mst_port_idx_t'(Cfg.NoMstPorts) ) There may be some PPA implications in non-static cases, but this approach should still properly return DECERR for routing to an unconnected region. |
Excellent! It is a very ingenious solution. |
…ove transmission efficiency and reduce the consumption of hardware resources
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
For demux, we can check the connectivity before routing, this can improve transmission efficiency. The more there are such case that connectivity[i][j] == 0 between slave_port[i] and mst_port[j], the better the improvement effect will be. Because the unnecessary arbitrations have been reduced, this accelerates the correct access response. At the same time, ensure that there is a dedicated port to receive decode errors as before.