-
Notifications
You must be signed in to change notification settings - Fork 92
treewide: Support narrow reduction operations #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
colluca
wants to merge
40
commits into
main
Choose a base branch
from
narrow_reduction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daaa34d to
d651676
Compare
af6df0a to
068dd7a
Compare
5453b0c to
47f46e1
Compare
bdfd98d to
b8ec8fd
Compare
b8ec8fd to
4432d89
Compare
b679cdd to
fca047f
Compare
Requires allocating the barrier pointer in the communicator in L1.
860b79e to
82e976e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reduction operations to the Snitch cluster.
On the narrow interface we add a separate CSR register which allows to set the user field of the narrow AXI interface.
The reduction/multicast (or collective communication) operation is encoded in the AXI user field of the narrow interface and is handled outside of the cluster.
On the wide interface a custom instruction was added to the iDMA, that allows to set the user field in its wide AXI requests.
All collective communication operations are handled outside of the cluster, even if the TCDM is selected as the destination. They are diverted to the external network interface from which they are then rerouted to the TCDM inside the cluster.
TODO: Clarify what assumptions are made on the user field, e.g. collective op in LSBs, etc.
In detail:
hw/reqrsp_interfacedirectory)hw/tcdm_interfacedirectory)dmmcastinstruction withdmuserCSR_MCASTwithCSR_USER_LOWand addCSR_USER_HIGHriscv-opcodesto reflect said changesuser_narrow_tanduser_dma_tparameters to cluster, and derive user widths from thesesnrt_fencefunctionsnrt_inter_cluster_barrier()cluster_base_offsetparameter to know the full (aligned) address space of the clustertests.mkto support tests from different directories. Update system integration docs accordingly. Also extend it to provide a PHONY target for each test.sn_include_depswhen overriding variables on the command-line. Bumppymakeutilsto include respective fix inlist-dependent-make-targets.TODO
CollectiveWidthparameter, in addition to the user types?