Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switch_python script to new default python version 3.9 #157

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Update switch_python script to new default python version 3.9 #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ENV XDG_CONFIG_HOME=/opt/settings
COPY dev_requirements.txt /dev_requirements.txt

COPY switch_python /usr/bin/switch_python
ARG PYTHON_VERSION=3.8
ARG PYTHON_VERSION=3.9
RUN switch_python "$PYTHON_VERSION"

RUN pip3 install -r dev_requirements.txt
Expand Down
4 changes: 2 additions & 2 deletions base/switch_python
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
set -e

NEWV=$1
if [[ "$NEWV" == "3.8" ]]; then
echo "using default python 3.8"
if [[ "$NEWV" == "3.9" ]]; then
echo "using default python 3.9"
exit 0
fi
Comment on lines +6 to 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's that useful? Isn't that preventing to ever switch back?
Sure if we used containers like they were designed, we'd just throw it away and create a new one. But if we used containers like they were designed, and not as a drop in replacement for vm's, we wouldn't have this script in the first place.


Expand Down
Loading