Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI module for better testability #44

Merged
merged 1 commit into from
May 24, 2024
Merged

Refactor CLI module for better testability #44

merged 1 commit into from
May 24, 2024

Conversation

pedro-psb
Copy link
Member

Refactor CLI module for better testability.

This does:

  • Creates PulpDocs instance, which uses a Config instance
  • Changes CLI to use PulpDocs instead of having the logic exposed there
  • Adds dry_run (enable testing correct option processing)

[noissue]

@pedro-psb pedro-psb merged commit 4751d9f into pulp:main May 24, 2024
3 checks passed
@pedro-psb pedro-psb deleted the add-functional-tests branch May 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pedro-psb