Add proper version information in quick-links page #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
force-pushed
the
add-correct-versions-to-plugins
branch
from
d726a19
to
091403e
Compare
mdellweg
reviewed
Jul 30, 2024
pyproject.toml
Outdated
| @@ -16,6 +16,7 @@ dependencies = [ | |||
| "importlib_resources", | |||
| "httpx", | |||
| "rich", | |||
| "tomli", | |||
There was a problem hiding this comment.
tomllib was added in python 3.11.
And I am pretty sure we can always run the docs workflow with a recent python version. Right?
So I'd prefer not to add a dependency.
BTW: In the same way I would prefer using importlib.resources over importlib_resources.
There was a problem hiding this comment.
Yes, we can always run the workflow with 3.11.
It's probably ok to use 3.11 since only CI and devs will use that (on their host machine, presumably).
I was just trying to play safe.
Also, updated 3rd party that was added to stdlib: - importlib.resources instead of importlib_resources - tomllib instead of tomli
mdellweg
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does:
Screenshots