Fix rest_api spec being fetched from outdated link #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
approved these changes
Sep 10, 2024
mdellweg
reviewed
Sep 10, 2024
src/pulp_docs/utils/general.py
Outdated
| """ | ||
| if repo_name == "pulpcore": | ||
| return "core" | ||
| # E.g: "pulp-ostree" -> "pulp_ostree" -> ("", "pulp_", "ostree") |
There was a problem hiding this comment.
Uhh, that's a bit of a dangerous assumption.
I guess the only way to "know" is to look into the template config of the plugin.
Does this run with all the plugins checked out side by side?
There was a problem hiding this comment.
Yes, it's possible to get from there, I'll do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the time of the docs transitioning pulp-docs was using the legacy server as a source of the api.json, which were doomed to become outdated. This was mostly to keep CI working while the solution was being implemented.
Now that the api schemas for docs are being generated in pulp-docs repo, we can use that as the up-to-date source.
Closes: #84