[PULP-255] Remove backward compatibility for manifest with artifact #1890
Conversation
dralley
force-pushed
the
remove-manifest-file-compat
branch
from
2b3b472 to
daf186d
Compare
pulp_container/app/registry_api.py
Outdated
| @@ -1120,7 +1120,7 @@ def handle_safe_method(self, request, path, pk): | |||
| self.fetch_manifest(remote, pk) | |||
| return redirects.redirect_to_content_app("manifests", pk) | |||
| elif manifest: | |||
| return redirects.issue_manifest_redirect(manifest) | |||
| return Response(manifest.data) | |||
There was a problem hiding this comment.
TODO: #1644 (comment)
There was a problem hiding this comment.
@git-hyagi @gerrod3 Any idea which headers specifically he was referring to?
There was a problem hiding this comment.
I was checking the OCI spec and found this:
"In a successful response, the Content-Type header will indicate the type of the returned manifest. The Content-Type header SHOULD match what the client pushed as the manifest's Content-Type. If the manifest has a mediaType field, clients SHOULD reject unless the mediaType field's value matches the type specified by the Content-Type header."
"A successful response SHOULD contain the digest of the uploaded blob in the header Docker-Content-Digest."
and searching the sample (return web.Response(...)) provided by Lubos, I found these headers definitions (which comply with the oci spec):
pulp_container/pulp_container/app/registry.py
Lines 137 to 142 in 18dab98
dralley
changed the title
dralley
force-pushed
the
remove-manifest-file-compat
branch
3 times, most recently
from
969fc97 to
5020597
Compare
dralley
force-pushed
the
remove-manifest-file-compat
branch
2 times, most recently
from
9a6be80 to
469bc7d
Compare
This commit removes support for manifests storing their data inside an artifact instead of using the recently introduced Manifest.data text field. closes pulp#1621
dralley
force-pushed
the
remove-manifest-file-compat
branch
from
469bc7d to
1bd73e3
Compare
This commit removes support for manifests storing their data inside an artifact instead of using the recently introduced Manifest.data text field.
closes #1621