Skip to content

Commit

Permalink
Update CI files
Browse files Browse the repository at this point in the history
[noissue]
  • Loading branch information
pulpbot authored and fao89 committed Aug 1, 2022
1 parent 56fd68e commit bfad487
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 9 deletions.
10 changes: 6 additions & 4 deletions flake8.cfg → .flake8
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
[flake8]
exclude = ./docs/*,*/migrations/*
ignore = W503,Q000,Q003,D100,D104,D106,D200,D205,D400,D401,D402,E203,D107
ignore = E203,W503,Q000,Q003,D100,D104,D106,D200,D205,D400,D401,D402
max-line-length = 100

# Flake8 builtin codes
# --------------------
# E203: no whitespace around ':'. disabled until https://github.com/PyCQA/pycodestyle/issues/373 is fixed
# W503: This enforces operators before line breaks which is not pep8 or black compatible.

# Flake8-quotes extension codes
# -----------------------------
# W503: This enforces operators before line breaks which is not pep8 or black compatible.
# Q000: double or single quotes only, default is double (don't want to enforce this)
# Q003: Change outer quotes to avoid escaping inner quotes

Expand All @@ -14,10 +18,8 @@ max-line-length = 100
# D100: missing docstring in public module
# D104: missing docstring in public package
# D106: missing docstring in public nested class (complains about "class Meta:" and documenting those is silly)
# D107: Missing docstring in __init__
# D200: one-line docstring should fit on one line with quotes
# D205: 1 blank line required between summary line and description
# D400: First line should end with a period
# D401: first line should be imperative (nitpicky)
# D402: first line should not be the function’s “signature” (false positives)
# E203: no whitespace around ':'. disabled until https://github.com/PyCQA/pycodestyle/issues/373 is fixed
2 changes: 1 addition & 1 deletion .github/template_gitref
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2021.08.26-150-gc95d3f2
2021.08.26-154-g7bcbd1f
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ jobs:
with:
python-version: "3.8"

# dev_requirements contains tools needed for flake8, etc.
# lint_requirements contains tools needed for flake8, etc.
- name: Install requirements
run: pip3 install -r dev_requirements.txt
run: pip3 install -r lint_requirements.txt

- name: Check commit message
if: github.event_name == 'pull_request'
Expand All @@ -52,7 +52,7 @@ jobs:
# Lint code.
- name: Run flake8
run: flake8 --config flake8.cfg
run: flake8

- name: Run extra lint checks
run: "[ ! -x .ci/scripts/extra_linting.sh ] || .ci/scripts/extra_linting.sh"
Expand Down
6 changes: 6 additions & 0 deletions lint_requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# python packages handy for developers, but not required by pulp
black
check-manifest
flake8
flake8-black

3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,12 @@ ignore = [
"dev_requirements.txt",
"doc_requirements.txt",
"docs/**",
"flake8.cfg",
"template_config.yml",
".pep8speaks.yml",
".ci/**",
".github/**",
"lint_requirements.txt",
".flake8",
]

[tool.black]
Expand Down

0 comments on commit bfad487

Please sign in to comment.