Rewrite test_sync.py using pytest
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hyagi
force-pushed
the
pytest-refactor-sync
branch
from
3aa8601
to
8c4248a
Compare
git-hyagi
force-pushed
the
pytest-refactor-sync
branch
from
8c4248a
to
8944ee1
Compare
lubosmj
requested changes
Jan 31, 2024
| repo = ostree_repositories_api_client.read(repo.pulp_href) | ||
| return ostree_repositories_versions_api_client.read(repo_version_href), remote, repo | ||
|
|
||
| def _synced_repo_version(repo=None, remote=None, policy="immediate"): |
There was a problem hiding this comment.
Suggested change
| def _synced_repo_version(repo=None, remote=None, policy="immediate"): | |
| def _sync_repo_version(repo=None, remote=None, policy="immediate"): |
And "sync_repo_version".
Comment on lines
99
to
101
| assert KeyError, lambda: added_content["ostree.refs"] | ||
| assert KeyError, lambda: added_content["ostree.commit"] | ||
| assert KeyError, lambda: added_content["ostree.object"] |
There was a problem hiding this comment.
These statements are always evaluated to True.
Try using pytest.raises instead, please: https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest.raises.
Comment on lines
150
to
151
| repo_version_href = repo.latest_version_href | ||
| repo = ostree_repositories_api_client.read(repo.pulp_href) |
There was a problem hiding this comment.
A safe bet would be running repo = ostree_repositories_api_client.read(repo.pulp_href) right after monitor_task in case the task's logic fails (defensive programming). With that, repo_version_href = repo.latest_version_href will definitely return the latest version of the repository.
git-hyagi
force-pushed
the
pytest-refactor-sync
branch
2 times, most recently
from
2c0275b
to
648744c
Compare
git-hyagi
force-pushed
the
pytest-refactor-sync
branch
from
648744c
to
9cc1952
Compare
lubosmj
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #327