Made another migration more robust when there are "broken" modulemds.

fixes #3196. (cherry picked from commit 2d7beda)
pulp · Jul 24, 2023 · a1ea6f9 · a1ea6f9
1 parent f14c9da
commit a1ea6f9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/CHANGES/3196.bugfix b/CHANGES/3196.bugfix
@@ -0,0 +1 @@
+Made 0049 migration more robust in the face of unexpected data.
diff --git a/pulp_rpm/app/migrations/0049_profiles_fix.py b/pulp_rpm/app/migrations/0049_profiles_fix.py
@@ -11,19 +11,20 @@ def fixup_modulemd_profiles(apps, schema_editor):
 
     for mmd in Modulemd.objects.all().iterator():
         modulemd = yaml.safe_load(mmd.snippet)
-        unprocessed_profiles = modulemd["data"].get("profiles", {})
-        profiles = {}
-        if unprocessed_profiles:
-            for name, data in unprocessed_profiles.items():
-                rpms = data.get("rpms")
-                if rpms:
-                    profiles[name] = rpms
-            mmd.profiles = profiles
-            modules_to_update.append(mmd)
-
-        if len(modules_to_update) >= 100:
-            Modulemd.objects.bulk_update(modules_to_update, ["profiles"])
-            modules_to_update.clear()
+        if modulemd:
+            unprocessed_profiles = modulemd["data"].get("profiles", {})
+            profiles = {}
+            if unprocessed_profiles:
+                for name, data in unprocessed_profiles.items():
+                    rpms = data.get("rpms")
+                    if rpms:
+                        profiles[name] = rpms
+                mmd.profiles = profiles
+                modules_to_update.append(mmd)
+
+            if len(modules_to_update) >= 100:
+                Modulemd.objects.bulk_update(modules_to_update, ["profiles"])
+                modules_to_update.clear()
 
     Modulemd.objects.bulk_update(modules_to_update, ["profiles"])