Add package filename filter

[daviddavis]

fixes #3215

[dralley]

LGTM functionality-wise, but I'm currently looking into whether we should ditch (or deprecate anyway) the location_href field in favor of something like "filename".

The reason being that location_href should never have existed in the current form to begin with, it stores the full path (think syncing), which doesn't really make much sense.

[daviddavis]

Ah, I knew that location_href stored the full path. I think that storing just the filename makes sense.

I'm pushing a change now that adds a "filename" filter. It looks like relative_path on the content artifact has just the filename (no path) so I think it should work and it won't depend on location_href.

[dralley]

At least at the moment I don't think this will work as-is because the relative path value isn't == filename, currently. But we should make it that way, IMO.

Or maybe I'm thinking of location_href and the relative path is just the filename. I need to check again...

[daviddavis]

Did you see the link I posted? It looks like in the sync code at least, relative_path is set to os.path.basename(package.location_href).

pulp_rpm/pulp_rpm/app/tasks/synchronizing.py

Lines 1312 to 1319 in d8cb08d

	filename = os.path.basename(package.location_href)
	da = DeclarativeArtifact(
	artifact=artifact,
	url=url,
	relative_path=filename,
	remote=self.remote,
	deferred_download=self.deferred_download,
	)