Fix policy schema for generic list remote

pulp · Jan 6, 2025 · dc902a8 · dc902a8
1 parent 6b9a035
commit dc902a8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/pulpcore/app/serializers/__init__.py b/pulpcore/app/serializers/__init__.py
@@ -87,6 +87,7 @@
 )
 from .purge import PurgeSerializer
 from .repository import (
+    GenericRemoteSerializer,
     RemoteSerializer,
     RepositorySerializer,
     RepositorySyncURLSerializer,

diff --git a/pulpcore/app/serializers/repository.py b/pulpcore/app/serializers/repository.py
@@ -165,7 +165,9 @@ class RemoteSerializer(ModelSerializer, HiddenFieldsMixin):
     )
     policy = serializers.ChoiceField(
         help_text="The policy to use when downloading content.",
-        choices=((models.Remote.IMMEDIATE, "When syncing, download all metadata and content now.")),
+        choices=(
+            (models.Remote.IMMEDIATE, "When syncing, download all metadata and content now."),
+        ),
         default=models.Remote.IMMEDIATE,
     )
 
@@ -323,6 +325,14 @@ class Meta:
         )
 
 
+class GenericRemoteSerializer(RemoteSerializer):
+    policy = serializers.ChoiceField(
+        help_text="The policy to use when downloading content.",
+        choices=models.Remote.POLICY_CHOICES,
+        default=models.Remote.IMMEDIATE,
+    )
+
+
 class RepositorySyncURLSerializer(ValidateFieldsMixin, serializers.Serializer):
     remote = DetailRelatedField(
         required=False,

diff --git a/pulpcore/app/viewsets/repository.py b/pulpcore/app/viewsets/repository.py
@@ -23,6 +23,7 @@
 from pulpcore.app.response import OperationPostponedResponse
 from pulpcore.app.serializers import (
     AsyncOperationResponseSerializer,
+    GenericRemoteSerializer,
     RemoteSerializer,
     RepairSerializer,
     RepositorySerializer,
@@ -330,7 +331,7 @@ class Meta:
 class ListRemoteViewSet(NamedModelViewSet, mixins.ListModelMixin):
     endpoint_name = "remotes"
     queryset = Remote.objects.all()
-    serializer_class = RemoteSerializer
+    serializer_class = GenericRemoteSerializer
     filterset_class = RemoteFilter
 
     DEFAULT_ACCESS_POLICY = {