Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] Backport migration workaround #6196

Draft
wants to merge 2 commits into
base: 3.49
Choose a base branch
from
Draft

[experiment] Backport migration workaround #6196

wants to merge 2 commits into from
+191 −46

Conversation

pedro-psb
Copy link
Member

The #6161 was not very good because it still added the field to the database.

This approaches adds a unique field to the branch which won't conflict with any future field.
It must be cleaned up later with an idempotent remove migration.

Still testing if it runs without a problem.

@pedro-psb
Add cooldown time for failed RemoteArtifact fetch
2f3b57b 
On a request for on-demand content in the content app, a corrupted Remote
that contains the wrong binary (for that content) prevented other Remotes
from being attempted on future requests.

Now the last failed Remotes are temporarily ignored and others may be picked.

[BACKPORT NOTES]
* removed the failed_at migration.
* on a different commit, a unique migration to this branch will be
  used as a replacement

Original issue pulp#5725
Backported from: pulp#6064
@pedro-psb
Backport workaround for adding RA cooldown
5fa9019 
Original backport with migration already removed:
2f3b57b

This adds unique migration field and update the code to use it.
This will avoid conflicts with future fields.

Must be cleaned up on a future release with an idempotent remove migration.
@pedro-psb pedro-psb marked this pull request as draft January 10, 2025 21:15
@pedro-psb
Copy link
Member Author

pedro-psb commented Jan 10, 2025 •
edited
Loading

My attempt to test the upgrade process:

  1. Start on 3.49 with a clean install
  2. checking out to main <-- errors [0]

I assume I'm missing some steps (update deps, ...?). Will continue on monday.

[0]:

[pulp]  | Traceback (most recent call last):
[pulp]  |   File "/usr/local/lib/python3.9/site-packages/gunicorn/arbiter.py", line 608, in spawn_worker
[pulp]  |     worker.init_process()
[pulp]  |   File "/src/pulpcore/pulpcore/app/entrypoint.py", line 47, in init_process
[pulp]  |     django.setup()
[pulp]  |   File "/usr/local/lib/python3.9/site-packages/django/__init__.py", line 24, in setup
[pulp]  |     apps.populate(settings.INSTALLED_APPS)
[pulp]  |   File "/usr/local/lib/python3.9/site-packages/django/apps/registry.py", line 124, in populate
[pulp]  |     app_config.ready()
[pulp]  |   File "/src/pulpcore/pulpcore/app/apps.py", line 258, in ready
[pulp]  |     super().ready()
[pulp]  |   File "/src/pulpcore/pulpcore/app/apps.py", line 134, in ready
[pulp]  |     self.import_viewsets()
[pulp]  |   File "/src/pulpcore/pulpcore/app/apps.py", line 171, in import_viewsets
[pulp]  |     from pulpcore.app.viewsets import NamedModelViewSet
[pulp]  |   File "/src/pulpcore/pulpcore/app/viewsets/__init__.py", line 1, in <module>
[pulp]  |     from .base import (
[pulp]  |   File "/src/pulpcore/pulpcore/app/viewsets/base.py", line 16, in <module>
[pulp]  |     from pulpcore.openapi import PulpAutoSchema
[pulp]  |   File "/src/pulpcore/pulpcore/openapi/__init__.py", line 13, in <module>
[pulp]  |     from drf_spectacular.plumbing import (
[pulp]  | ImportError: cannot import name 'process_webhooks' from 'drf_spectacular.plumbing' (/usr/local/lib/python3.9/site-packages/drf_spectacular/plumbing.py)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
multi-commit no-changelog no-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pedro-psb