CI: Fix workaround for Homebrew node in Cirrus on macOS #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround was necessary before because something broke. Now the workaround is the thing that breaks things. Go figure.
Apparently it's not the "node" cask anymore in the base CI image, it's the "node@20" cask. Wow. The workaround of uninstalling this is still needed, it's just that the package name has changed.
DeeDeeG
changed the title
DeeDeeG
changed the title
savetheclocktower
approved these changes
May 14, 2024
|
Thanks for the review. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround was necessary before because something broke.
Now the workaround is the thing that breaks things.
Go figure. [EDIT: workaround just needed to be tweaked to hit the right package name. Mostly still valid after all.]
Follow-up to #961.
This one is a little more straight-forward than 961, thank goodness. Apparently, Homebrew's
nodecask is not preinstalled anymore in the latest CI base images we've been auto-updated to, so trying to remove it gives an error now.Solution: Don't do that. 👍 (Remove
node@20cask instead!)Verification Process
Ran this through Cirrus via a custom cron job. It worked. CI is passing for that run with the fix. 👍
https://cirrus-ci.com/task/5146025353019392