-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-sitter rolling fixes, 1.122 edition #1101
Conversation
The first of what will hopefully be a series of similar additions, ordered (roughly) by grammar complexity.
…into a new `common/highlights.scm`. Add highlighting specs for C and C++ Tree-sitter grammars.
…that was inadvertently deleted.
…when two folds share a boundary.
I meant to put this in draft mode like the others, so pretend I just took it out of draft mode! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks a lot like many of your past improvements.
Love to see exceptional testing on this, gives lots of faith to the passing specs on these changes.
Sorry if this is something I've just missed in the past, but was there a change we made to support the languageSegment
and highlightsQuery
keys? It seems it just allows us to define multiple highlight query files, which is awesome as I assume that reduces duplication and effort, but I'm curious if there's anything big we had to do previously to support this? Or has it always been around as a possibility?
Every That's been around for a while; I think I created it so that I could cut down on redundancy between the TypeScript and TypeScript-with-TSX grammars. If I'd had it in place when I first wrote the C and C++ highlighting I would've used it there as well. It's documented in the Sharing query files section. |
@savetheclocktower Thanks for taking the time to answer my question, and super awesome you've already written some documentation for it! But seems we should be good to merge then! |
#1100 gives me a great excuse to get the new Tree-sitter PR up. Unlike last month's PR, this one starts off small.
Fixes #1100.
Changelog
#ifdef
s in C/C++).