Restore ability for packages to focus specs… #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on both Jasmine 1 and Jasmine 2 test runners.
Also restore behavior of failing immediately in CI if a test is accidentally left focused.
These were some loose ends left over from #990. Focusing specs (changing
it
tofit
ordescribe
tofdescribe
) was already working within Pulsar's own test suite for Jasmine 2 tests, but not on package specs running Jasmine 2, nor on package specs running Jasmine 1.I don't like it when my head hurts, so I've not delved too deeply into determining how the core suite was able to use
fit
(despite the fact that I couldn't figure out how or where it was defined) but not a package. I just know that thejasmine-focused
andjasmine2-focused
packages solve this for Jasmine 1 and 2, respectively.The Jasmine 2 runner also needed a way to fail the tests in CI if any test was accidentally left focused. I found this out the hard way when that very thing happened to me in #1249.