Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron-rebuild #734

Closed
wants to merge 3 commits into from
Closed

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented Sep 20, 2023

Hopefully fixes #733.

Updates electron-rebuild to 3.3.0. See https://discord.com/channels/992103415163396136/992109539346370661/1151516275118444695 and laurent22/joplin#8777.

No I've got no idea why this might fix it, the electron-rebuild change log doesn't seem to indicate a specific fix here.

Also updates the package name of electron-rebuild which stops at 3.2.9.
image

@confused-Techie
Copy link
Member

While the changes here look good, it seems that unfortunately things are failing to build on Windows. But finding the solution to that, I'd love to get this one merged!

@confused-Techie
Copy link
Member

Also I find this interesting.

Looking at the logs of my other open PR I see: electron-rebuild not required if you use electron-builder, please consider to remove excess dependency from devDependencies

But meanwhile looking at the logs of the build attached here, I don't see that same notice. So a little weird, but maybe relevant?

@Daeraxa
Copy link
Member Author

Daeraxa commented Sep 24, 2023

I think there isn't really much point in merging this as it hasn't fixed what I hoped. At most all it does is update the version of electron-rebuild and move to the new package name as it has moved.

We should at least be aware of that second item but I don't think this is worth merging if it didn't do what we wanted (see the conversation in the issue this was designed to fix). If we do want to do that I can just rename the PR and description to at least be meaningful.

@Daeraxa
Copy link
Member Author

Daeraxa commented Oct 12, 2023

Doesn't work so closing.

@Daeraxa Daeraxa closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run on Almalinux 8
2 participants